eladkal commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r871589511
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
don't get me wrong.. if you think it's best to use the new name we can do
the deprecation..
it's not that complex it just add 3-4 code lines :)
See for example:
https://github.com/apache/airflow/blob/ccb5ce934cd521dc3af74b83623ca0843211be62/airflow/providers/trino/hooks/trino.py#L165-L173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
