kalyani-subbiah commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r871570508
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
Good point. In that case we can keep the argument `local_path`.
If a local_path variable is a path to a directory, then we run
`download_fileobj` from boto3. If its a path to a file, then we run
`download_file` from boto3. I think this workflow would be non-breaking.
We would still have to update the docs to reflect this change though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
