eladkal commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r871554233
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
Please also don't rename the parameter like that.
renaming it is a breaking change and we don't want to break user code if we
can avoid it.
Users may use this function directly in thier code.
If you decide that it's best to rename (and can explain why this rename is
needed) then you must support both `local_path` and `filename`.
for local_path you need to raise deprecation warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
