kalyani-subbiah commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r871477956
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
Thanks for the review.
Good catch on the filename - I can change its type from Optional[str] to
str.
Not sure where to edit the docs for the s3_hook, the link at the bottom of
the page:
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/_api/airflow/providers/amazon/aws/hooks/s3/index.html
that reads: "Suggest a change on this page" gives me a 404 error:
https://github.com/apache/airflow/edit/main/docs/apache-airflow-providers-amazon/_api/airflow/providers/amazon/aws/hooks/s3/index.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
