kalyani-subbiah commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r872565464
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
Hi! I have updated this pull request based on the feedback above. It's now
non-breaking. Thanks so much everyone.
I've added a conditional for using local_path as path to a directory or a
file.
Also added an additional unit-test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
