dstandish commented on code in PR #27763:
URL: https://github.com/apache/airflow/pull/27763#discussion_r1026972538
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -294,6 +297,14 @@ def _run_command(self, cur, sql_statement, parameters):
if cur.rowcount >= 0:
self.log.info("Rows affected: %s", cur.rowcount)
+ def _update_query_ids(self, cursor) -> None:
Review Comment:
Ok so if we keep this, i'd prefer to make the interface on DBApi more
generic, like `_post_execute_hook`. Or something like that. Maybe there's a
better name out there. Then snowflake can implement it and use it to store the
query ids.
One problem is that hooks do a variety of executing in a variety of
contexts. So, perhaps we can come up with something that's a little more
generic, i.e. compatible with if, say, we wanted to add a hook / callback in a
different context within the functionality of the hook.
Meanwhile, I'm checking with @mobuchowski to see whether we still need query
ids on snowflake hook for the original purpose (which was lineage) or whether
we are now scraping that info some other way.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
