potiuk commented on PR #27763: URL: https://github.com/apache/airflow/pull/27763#issuecomment-1325288721
I think we need to approach any such changes very, very carefully after https://github.com/apache/airflow/pull/27854 and https://github.com/apache/airflow/issues/27838 - this is really manifestation of the fact that when code is closely coupled, separating common functionality to separate "component" is HARD and have to be very, carefully reviewed. The scenarios where old providers use new common.sql have to be carefully considered - and this is what should happen before we merge this one. Possibly we should even wait until we add some automated tests to verify some of the faillure scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
