potiuk commented on code in PR #27763:
URL: https://github.com/apache/airflow/pull/27763#discussion_r1029747222
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -294,6 +297,14 @@ def _run_command(self, cur, sql_statement, parameters):
if cur.rowcount >= 0:
self.log.info("Rows affected: %s", cur.rowcount)
+ def _update_query_ids(self, cursor) -> None:
Review Comment:
Just for the record - see the k
ind of problems that the common.sql MIGHT introduce if we remove some
seeminglly unused methods.
https://github.com/apache/airflow/issues/27838
I think we should be very, very, very careful when we remove anything from
common.sql provider. Because we might simply not realize that it has been used.
This is the effect of common code in full swing if you do not have very
well defined "public API" upfront AND you do not check (Python WTF) that even
if you declared something as protected, some other entity might rely on it.
This is the learnings we should have that once we make some code common and
used elsewhere, refactoring and removing stuff from it should be done extremely
carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
