dstandish commented on code in PR #27763:
URL: https://github.com/apache/airflow/pull/27763#discussion_r1029985962
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -294,6 +297,14 @@ def _run_command(self, cur, sql_statement, parameters):
if cur.rowcount >= 0:
self.log.info("Rows affected: %s", cur.rowcount)
+ def _update_query_ids(self, cursor) -> None:
Review Comment:
hey @potiuk i thought your position was "let's just break things" ;)
@mobuchowski it looks like you rely on such an attr on the _operator_ class
not the _hook_
is that correct? To me, that makes a lot more sense. Although, it looks
like in `main` this may be broken, because I do not see anything that touches
the `query_ids` attr on this operator after init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
