mobuchowski commented on code in PR #27763:
URL: https://github.com/apache/airflow/pull/27763#discussion_r1030595524
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -294,6 +297,14 @@ def _run_command(self, cur, sql_statement, parameters):
if cur.rowcount >= 0:
self.log.info("Rows affected: %s", cur.rowcount)
+ def _update_query_ids(self, cursor) -> None:
Review Comment:
@dstandish you're right, we're using it on operator - looks like it was
broken on https://github.com/apache/airflow/pull/25717.
It's not a critical for us - we can accept this breakage if we can agree on
exposing this kind of information from hooks via operators in any other way. I
think it would be useful for any other kinds of metadata.
For example, I dislike the fact that `SQLExecuteQueryOperator` gets hook in
execute method, but does not set it as `self` instance variable.
There's a lot to be done on how to expose execution metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
