potiuk commented on PR #30873:
URL: https://github.com/apache/airflow/pull/30873#issuecomment-1534405593
> Looks like the root cause for the docker-compse test failing is
`ModuleNotFoundError: No module named 'opentelemetry'`. I think what it needs
is a new prod image at `ghcr.io/apache/airflow/main/prod/python3.7:latest`
which has the opentelemetry module installed, maybe??
Ah. No this is actually A sign of our failign test detecting a REAL problem
(this is what the tests are for :) ). Our PROD docker image does not have
opentelemetry extra installed but apparently the change makes it a requirement
for airflow.
In setup.py we have:
```
otel = ["opentelemetry-api==1.15.0", "opentelemetry-exporter-otlp",
"opentelemetry-exporter-prometheus"]
```
followed by extra definition below
```
"otel": otel,
```
And for me this is a sign that we should have at the very least
"opentelemetry-api" moved to install-requires in `setup.cfg` which means that
we should make it part of the requirements of core airflow packge.
Which makes perfect sense if you think we are actually going to use open
telemetry as our default metrics interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
