potiuk commented on PR #30873: URL: https://github.com/apache/airflow/pull/30873#issuecomment-1534435199
BTW. I am so glad the test caught that one. This `docker-compose` test was SPECIFICALLY designed to catch exactly this kind of problem. It tests if everything we have in the PR works together: * It builds locally all our soources into packages (airflow and those packages that are installed in the image by default) * it uses THOSE locally built airflow packages (not the ones coming from `pypi` to build airflow PROD image locally * It builds that locally build prod image to run our docker-compose airflow quick start and runs a simple test with it Similarly we have kubernetes Helm tests that would also fail (but this one is only run when kubernetes changes are involved in airflow. So it would have failed in `canary` builds in similar way.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
