dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664372781
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -140,32 +141,6 @@ def _interleave_logs(*logs):
last = v
-def _ensure_ti(ti: TaskInstanceKey | TaskInstance | TaskInstancePydantic,
session) -> TaskInstance:
Review Comment:
i would personally rather have duplication, or "internal" importing of
single underscore methods, than unnecessarily expanding public interface. it's
a real pain when we have to worry about making updates to things that no user
should be using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
