dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664365215


##########
airflow/executors/base_executor.py:
##########
@@ -122,6 +123,7 @@ class BaseExecutor(LoggingMixin):
     job_id: None | int | str = None
     name: None | ExecutorName = None
     callback_sink: BaseCallbackSink | None = None
+    task_context_logger: TaskContextLogger

Review Comment:
   the class `TaskContextLogger` is private (see the sphinx directive in the 
docstring) so ... really we should either make it public or do not use it in 
providers.
   
   the intention was to keep it internal since it's not something users should 
really mess with and in that scenario best to retain flexibility to change it 
at will.
   
   possible solution: is there a way that this can be managed through the 
executor interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to