dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664371338
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -140,32 +141,6 @@ def _interleave_logs(*logs):
last = v
-def _ensure_ti(ti: TaskInstanceKey | TaskInstance | TaskInstancePydantic,
session) -> TaskInstance:
Review Comment:
i am not sure why move this to task context logger. maybe you could share
your reasoning? file task handler seems lower level if anything. but yea if
you are going to remove the single underscore, please add `:meta private:` so
this does not become public interface unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
