vincbeck commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664410121
##########
airflow/executors/base_executor.py:
##########
@@ -122,6 +123,7 @@ class BaseExecutor(LoggingMixin):
job_id: None | int | str = None
name: None | ExecutorName = None
callback_sink: BaseCallbackSink | None = None
+ task_context_logger: TaskContextLogger
Review Comment:
> possible solution: is there a way that this can be managed through the
executor interface?
How? At the end, we'll have to use `TaskContextLogger` in providers. Unless
you want to copy `TaskContextLogger` in providers?
I am not sure this is a huge risk to make it public, the only public methods
of this class are the emitting log methods such as `error`, `info`, ... The
signature of these methods are pretty generic and the risk to have a breaking
change is pretty low?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
