vincbeck commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664575161
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -386,14 +385,16 @@ def attempt_task_runs(self):
)
self.pending_tasks.append(ecs_task)
else:
- self.log.error(
- "ECS task %s has failed a maximum of %s times. Marking
as failed",
+ self.task_context_logger.error(
Review Comment:
That's a good call. I can go through again the different scenarios and
narrow them down to a few. TBH, I just went through all the `self.log.error(`
thinking whatever error happens on the executor side, the user should know
about it. But I guess I can apply a slightly smarter filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
