dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664469242
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -386,14 +385,16 @@ def attempt_task_runs(self):
)
self.pending_tasks.append(ecs_task)
else:
- self.log.error(
- "ECS task %s has failed a maximum of %s times. Marking
as failed",
+ self.task_context_logger.error(
Review Comment:
similar comment here. just consider it everywhere. are you introducing
usages of taskcontextlogger that (1) are not really necessary because the user
will get enough information already or (2) just occur too frequently, so that
the scheduler will now have to upload logs to s3 routinely during its loop.
because of the performance considerations, the feature should really only be
used when the user would otherwise have no information about what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
