vincbeck commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664593528
##########
airflow/executors/base_executor.py:
##########
@@ -122,6 +123,7 @@ class BaseExecutor(LoggingMixin):
job_id: None | int | str = None
name: None | ExecutorName = None
callback_sink: BaseCallbackSink | None = None
+ task_context_logger: TaskContextLogger
Review Comment:
> One thing change we need to make with this interface, that I think was
missed, is that each file needs to have a random string in it because,
especially as more usages of this are added, there will be times when multiple
such messages are added for a single TI, and currently, if they are from the
same "component", then they will collide / override.
Are you sure about this? `TaskContextLogger` is currently being used int eh
scheduler with a component name static, thus, if you're right, that'd mean that
scheduler logs override each other? Or I misunderstood what you said.
https://github.com/apache/airflow/blob/main/airflow/jobs/scheduler_job_runner.py#L240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
