vincbeck commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664583508
##########
airflow/executors/base_executor.py:
##########
@@ -149,7 +155,7 @@ def queue_command(
self.log.info("Adding to queue: %s", command)
self.queued_tasks[task_instance.key] = (command, priority, queue,
task_instance)
else:
- self.log.error("could not queue task %s", task_instance.key)
+ self.task_context_logger.error("could not queue task %s",
task_instance.key, ti=task_instance)
Review Comment:
I like the idea and I think it can be valuable for Airflow users, but that'd
deserve an AIP (or at least a message de dev list to ask feedbacks). Though, I
still do think we need to send logs to task logs in executors (and also other
components of Airflow). If the executor is unable to do something about a given
task, the user should know about it with all the possible details (stacktrace),
so I think we still have this problem we need to solve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
