dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664471730
##########
airflow/executors/base_executor.py:
##########
@@ -149,7 +155,7 @@ def queue_command(
self.log.info("Adding to queue: %s", command)
self.queued_tasks[task_instance.key] = (command, priority, queue,
task_instance)
else:
- self.log.error("could not queue task %s", task_instance.key)
+ self.task_context_logger.error("could not queue task %s",
task_instance.key, ti=task_instance)
Review Comment:
here's another thought for you. perhaps instead of using task context logger
for every failure, we should add a `reason` field to go along with `state`, so
that we can add a small message about what happened / why the task ended up in
the state that it did, and then we would not need to use this, unfortunately
clunky and not-super-good-for-performance feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
