Github user tliron commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153014666
--- Diff: aria/utils/threading.py ---
@@ -161,11 +242,7 @@ def close(self):
self._workers = None
def drain(self):
- """
- Blocks until all current tasks finish execution, but leaves the
worker threads alive.
- """
-
- self._tasks.join() # oddly, the API does not support a timeout
parameter
+ self._tasks.join() # oddly, the API does not support a timeout
parameter
--- End diff --
Hm, I always hated this, and a lot of projects ignore it. Right now we have
a mix of styles.
Let's put this as a separate JIRA and maybe change all our comments at once?
---
