Github user aviyoop commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153151961
--- Diff: aria/parser/loading/loader.py ---
@@ -32,3 +32,6 @@ def close(self):
def load(self):
raise NotImplementedError
+
+ def get_canonical_location(self):
# pylint: disable=no-self-use
--- End diff --
That every method definition that is just used to 'declare' it to the
inheriting classes should return `NotImplementedError`. and overriding methods
should do what they want to do.
---
