Github user tliron commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153343290
--- Diff: aria/utils/threading.py ---
@@ -161,11 +242,7 @@ def close(self):
self._workers = None
def drain(self):
- """
- Blocks until all current tasks finish execution, but leaves the
worker threads alive.
- """
-
- self._tasks.join() # oddly, the API does not support a timeout
parameter
+ self._tasks.join() # oddly, the API does not support a timeout
parameter
--- End diff --
Sure, but for better or for worse it's what we have right now. I did enough
sweeping fixes in this PR to get people mad at me, I suggest postponing this
one for a different PR.
---
