Github user aviyoop commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153148567
--- Diff: aria/parser/reading/yaml.py ---
@@ -82,7 +84,11 @@ def read(self):
# see issue here:
#
https://bitbucket.org/ruamel/yaml/issues/61/roundtriploader-causes-exceptions-with
#yaml_loader = yaml.RoundTripLoader(data)
- yaml_loader = yaml.SafeLoader(data)
+ try:
+ # Faster C-based loader, might not be available on all
platforms
+ yaml_loader = yaml.CSafeLoader(data)
+ except BaseException:
--- End diff --
so why no `except Exception`?
In this case, you won't ignore a shutdown or an interrupt signal, but any
'programmatic' error will be caught.
---