Github user aviyoop commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153196429
  
    --- Diff: aria/utils/threading.py ---
    @@ -161,11 +242,7 @@ def close(self):
             self._workers = None
     
         def drain(self):
    -        """
    -        Blocks until all current tasks finish execution, but leaves the 
worker threads alive.
    -        """
    -
    -        self._tasks.join()  # oddly, the API does not support a timeout 
parameter
    +        self._tasks.join() # oddly, the API does not support a timeout 
parameter
    --- End diff --
    
    OK. But to be exact, the 'mix of styles' is your style (and PRs you 
reviewed), and everyone else's style =)


---

Reply via email to