[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120660&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120660
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 08:04
Start Date: 09/Jul/18 08:04
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5729: [BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200912362
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -190,12 +192,29 @@ def __init__(self, end):
def max_timestamp(self):
return self.end.predecessor()
- def __cmp__(self, other):
+ def cmp(self, other):
# Order first by endpoint, then arbitrarily.
- return cmp(self.end, other.end) or cmp(hash(self), hash(other))
+ end_cmp = (self.end > other.end) - (self.end < other.end)
+ hash_cmp = (hash(self) > hash(other)) - (hash(self) < hash(other))
+ return end_cmp or hash_cmp
def __eq__(self, other):
- raise NotImplementedError
+ return self.cmp(other) == 0
Review comment:
It doesn't look like this takes care of the case where other is not of type
`BoundedWindow`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120660)
Time Spent: 3h 40m (was: 3.5h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
