[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=120661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120661
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 08:04
Start Date: 09/Jul/18 08:04
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5729: [BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r200912860
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -245,10 +265,19 @@ def __init__(self, value, timestamp):
self.value = value
self.timestamp = Timestamp.of(timestamp)
- def __cmp__(self, other):
+ def __eq__(self, other):
+ type_eq = type(self) == type(other)
+ value_eq = self.value == other.value
+ timestamp_eq = self.timestamp == other.timestamp
+ return type_eq and value_eq and timestamp_eq
Review comment:
This will not work correctly, as the previous code relied on the
short-circuiting behavior of "and". Accessing `other.value` will not work if
the type is not as we expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120661)
Time Spent: 3h 40m (was: 3.5h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
