danny0405 commented on a change in pull request #1869: [CALCITE-3868] Remove 
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r396943660
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
 ##########
 @@ -130,24 +125,15 @@ public void checkCancel() {
    *
    * @param rule Rule
    */
-  protected void mapRuleDescription(RelOptRule rule) {
-    // Check that there isn't a rule with the same description,
-    // also validating description string.
-
+  protected boolean mapRuleDescription(RelOptRule rule) {
+    // Check that there isn't a rule with the same description
     final String description = rule.toString();
     assert description != null;
-    assert !description.contains("$")
-        : "Rule's description should not contain '$': "
-        + description;
-    assert !INTEGER_PATTERN.matcher(description).matches()
-        : "Rule's description should not be an integer: "
 
 Review comment:
   How should we validate the rule description pattern now ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to