danny0405 commented on a change in pull request #1869: [CALCITE-3868] Remove
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r397599083
##########
File path:
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
##########
@@ -156,16 +142,18 @@ protected void mapRuleDescription(RelOptRule rule) {
+ "existing rule=" + existingRule + "; new rule=" + rule);
}
}
+ return true;
}
/**
* Removes the mapping between a rule and its description.
*
* @param rule Rule
+ * @return the rule that is removed, or null if no rule is removed
*/
- protected void unmapRuleDescription(RelOptRule rule) {
+ protected RelOptRule unmapRuleDescription(RelOptRule rule) {
Review comment:
The parameter of this method is weird, should be string description of the
rule, like `removeRule(String desc)` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
