zabetak commented on a change in pull request #1869: [CALCITE-3868] Remove
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r396993936
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -392,35 +382,24 @@ public RelSet getSet(RelNode rel) {
this.mapRel2Subset.clear();
this.relImportances.clear();
this.ruleQueue.clear();
- this.ruleNames.clear();
this.materializations.clear();
this.latticeByName.clear();
this.provenanceMap.clear();
}
public List<RelOptRule> getRules() {
- return ImmutableList.copyOf(ruleSet);
+ return ImmutableList.copyOf(mapDescToRule.values());
}
public boolean addRule(RelOptRule rule) {
Review comment:
If we choose to add this method to the superclass (instead of having
`mapRuleDescription`) then here we can ovverride.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
