zabetak commented on a change in pull request #1869: [CALCITE-3868] Remove
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r396992730
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -392,35 +382,24 @@ public RelSet getSet(RelNode rel) {
this.mapRel2Subset.clear();
this.relImportances.clear();
this.ruleQueue.clear();
- this.ruleNames.clear();
this.materializations.clear();
this.latticeByName.clear();
this.provenanceMap.clear();
}
public List<RelOptRule> getRules() {
Review comment:
Would it be a good idea to move the method to `AbstractRelOptPlanner`? This
would allow us to keep `mapDescToRule` private and replace calls to
`mapDescToRule.values()` with calls to this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
