zabetak commented on a change in pull request #1869: [CALCITE-3868] Remove
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r396987477
##########
File path:
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
##########
@@ -44,18 +44,13 @@
* Abstract base for implementations of the {@link RelOptPlanner} interface.
*/
public abstract class AbstractRelOptPlanner implements RelOptPlanner {
- //~ Static fields/initializers ---------------------------------------------
-
- /** Regular expression for integer. */
- private static final Pattern INTEGER_PATTERN = Pattern.compile("[0-9]+");
-
//~ Instance fields --------------------------------------------------------
/**
* Maps rule description to rule, just to ensure that rules' descriptions
* are unique.
*/
- private final Map<String, RelOptRule> mapDescToRule = new HashMap<>();
+ protected final Map<String, RelOptRule> mapDescToRule = new HashMap<>();
Review comment:
With this change the map becomes the main data structure holding the rules
so I think the Javadoc should be updated to reflect this. Increasing the
visibility of the field makes it public API; it might be better to keep this
private and rely on public/protected methods to recover the necessary info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
