[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

Thu, 30 Apr 2020 04:01:20 -0700 


rubenada commented on a change in pull request #1937:
URL: https://github.com/apache/calcite/pull/1937#discussion_r417928414



##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -730,6 +743,11 @@ public static boolean le(String b0, String b1) {
     return b0.compareTo(b1) <= 0;
   }
 
+  /** SQL <code>&le;</code> operator applied to String values. */

Review comment:
       I prefer to leave them for backwards compatibility




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to