rubenada commented on a change in pull request #1937:
URL: https://github.com/apache/calcite/pull/1937#discussion_r417928946
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java
##########
@@ -279,4 +281,18 @@ public final String getCollationName() {
public final SqlCollation.Coercibility getCoercibility() {
return coercibility;
}
+
Review comment:
Re-refactored, and back to inheritance (JavaCollation extends
SqlCollation), but equals/hashCode should work fine in that case too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
