asereda-gs commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r781789087
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
"aggregations:{'v1.max.field': 'val1'",
"'v2.min.field': 'val2'}"))
.returnsUnordered("v1=7; v2=5");
+ }
+
+ @Test void testNullsSort() {
Review comment:
I'm not sure you need a very big dataset, just a smart one.
Personally I find it easier to add test documents (for ES) directly in java
code see
[AggregationTest](https://github.com/apache/calcite/blob/cdf9d700183d926780f4e5b57d6211a85a548506/elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java#L72-L74)
and then run different queries against them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
