herunkang2018 commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1195788974
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
}
@Override public @Nullable SqlValidatorTable getTable() {
+ if (resolvedNamespace == null) {
+ validator.validateNamespace(this, validator.unknownType);
+ }
return resolvedNamespace == null ? null : resolve().getTable();
Review Comment:
In thie PR, `resolvedNamespace == null` check seems not good enough, I want
a clearer way to indicate that the namespace has been validated, I check that
`resolvedNamespace` and `rowType` should be set after validation, but in
`SqlAdvisorValidator`, these two variables remains null in unresolved table's
namespace, which is hard to check whether namespace has been validated or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
