herunkang2018 commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1199072498
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
}
@Override public @Nullable SqlValidatorTable getTable() {
+ if (resolvedNamespace == null) {
+ validator.validateNamespace(this, validator.unknownType);
+ }
return resolvedNamespace == null ? null : resolve().getTable();
Review Comment:
In current fix, the call path is `validator.validateNamespace` ->
`namespace.validate` -> `AbstractNamespace.validate`, so the validation status
has been protected yet. I find this is the same way used in
`AbstractNamespace.getRowType`, so I don't understand your point very clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
