tanclary commented on code in PR #3495:
URL: https://github.com/apache/calcite/pull/3495#discussion_r1380479121
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -1141,14 +1141,88 @@ private void
checkColumnUniquenessForFilterWithConstantColumns(String sql) {
.assertThatAreColumnsUnique(bitSetOf(0, 1), is(false));
}
+ @Test void testColumnUniquenessForLimit1() {
+ final String sql = ""
+ + "select *\n"
+ + "from emp\n"
+ + "limit 1";
Review Comment:
Based on other test files I don't know if I have found other examples like
this outside of this class although I do agree it looks nice. I personally
favor consistency (see `SqlOperatorTest`, `RelToSqlConverterTest`,
`SqlParserTest` for how other popular test classes are formatted).
I wouldn't say I feel necessarily strong about it but I think if we format
every test in the same way it gives us one less thing to think about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
