julianhyde commented on code in PR #3495:
URL: https://github.com/apache/calcite/pull/3495#discussion_r1405478177
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -1141,14 +1141,88 @@ private void
checkColumnUniquenessForFilterWithConstantColumns(String sql) {
.assertThatAreColumnsUnique(bitSetOf(0, 1), is(false));
}
+ @Test void testColumnUniquenessForLimit1() {
+ final String sql = ""
+ + "select *\n"
+ + "from emp\n"
+ + "limit 1";
Review Comment:
Definitely don't go changing unrelated code. When a reviewer is asking for
consistency, they are never asking for that.
There often inconsistencies when people have applied judgment. If there you
can find reasons for those inconsistencies - even if they are reasons you don't
personally agree with - it's not constructive to harp on those inconsistencies,
because in so doing, you are criticizing people for applying judgment.
I would tend to write
```
String sql1 = "select x\n"
+ "from t";
String sql2 = ""
+ "select (select * from
aVeryComplicatedSubqueryThatWouldMakeTheLineTooLong)\n"
+ from t";
```
There is a consistent rule there, if you look for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
