PaulJackson123 commented on code in PR #3495:
URL: https://github.com/apache/calcite/pull/3495#discussion_r1380600646
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -1141,14 +1141,88 @@ private void
checkColumnUniquenessForFilterWithConstantColumns(String sql) {
.assertThatAreColumnsUnique(bitSetOf(0, 1), is(false));
}
+ @Test void testColumnUniquenessForLimit1() {
+ final String sql = ""
+ + "select *\n"
+ + "from emp\n"
+ + "limit 1";
Review Comment:
I can make the change but knowing where to stop is a bit tricky. Do I change
just mine, all the ones in this file, all the ones in the files I changed, or
all in all test files? I found 550 occurrences in Test, 372 in core:
<img width="485" alt="image"
src="https://github.com/apache/calcite/assets/16478647/6e6e08dc-7abc-4855-957e-672ff60e209b";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
