PaulJackson123 commented on code in PR #3495:
URL: https://github.com/apache/calcite/pull/3495#discussion_r1380313763
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -1141,14 +1141,88 @@ private void
checkColumnUniquenessForFilterWithConstantColumns(String sql) {
.assertThatAreColumnsUnique(bitSetOf(0, 1), is(false));
}
+ @Test void testColumnUniquenessForLimit1() {
+ final String sql = ""
+ + "select *\n"
+ + "from emp\n"
+ + "limit 1";
Review Comment:
I see that it is not consistent. There are quite a few like this in both
this class and `RelOptRulesTest`. I did make the change everywhere and it was
mostly fine with one exception - `testPullUpPredicatesFromUnion2`. In that case
the SQL extends beyond the end of line and requires formatting that, IMO, makes
it less pleasing.
I'd like to ask how strongly you feel about this one. One argument for
leaving it as is is it makes all the lines of the SQL start on the same column,
which I think is nice.
I will fix the issue with too much leading space on lines 1146-1148 and
elsewhere. I must not have had my Code Style set properly when I wrote these
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
