rubenada commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1770942617
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/AbstractNode.java:
##########
@@ -51,7 +51,7 @@ public Type getType() {
}
@Override public String toString() {
- ExpressionWriter writer = new ExpressionWriter(true);
+ ExpressionWriter writer = new ExpressionWriter(true, true);
Review Comment:
Will this have any practical impact on the actual code generation? (like
splitting in some circumstances where the CalciteSystemProperty has not been
set to true). If not, I'd say this is acceptable.
It's true that it is a bit unfortunate that we cannot check the
CalciteSystemProperty here, but I can't think of a better solution at this
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
