rubenada commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1770951227
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java:
##########
@@ -70,8 +70,8 @@ public static String toString(List<? extends Node>
expressions, String sep,
/**
* Converts an expression to Java source code.
*/
- public static String toString(Node expression) {
- return toString(Collections.singletonList(expression), "", true);
+ public static String toString(Node expression, boolean methodSplit) {
Review Comment:
Since we are touching public methods of a public class, to facilitate
backwards compatibility I wonder if it would make sense to overload these
`toString` methods (to have a "default false methodSplit", in case any
downstream project was using them directly):
```
public static String toString(List<? extends Node> expressions, String sep,
boolean generics) {
return toString(expressions, sep, generics, false);
}
public static String toString(Node expression) {
return toString(expression, false);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
