jduo commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1774207570
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java:
##########
@@ -70,8 +70,8 @@ public static String toString(List<? extends Node>
expressions, String sep,
/**
* Converts an expression to Java source code.
*/
- public static String toString(Node expression) {
- return toString(Collections.singletonList(expression), "", true);
+ public static String toString(Node expression, boolean methodSplit) {
Review Comment:
Done in
[dc1c66d](https://github.com/apache/calcite/pull/3901/commits/dc1c66d14b38ad122312b99861fca20794701504)
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/MethodDeclaration.java:
##########
@@ -57,20 +60,39 @@ public MethodDeclaration(int modifier, String name, Type
resultType,
}
@Override public void accept(ExpressionWriter writer) {
- String modifiers = Modifier.toString(modifier);
- writer.append(modifiers);
+ final ExpressionWriter writerForUnsplitMethod =
writer.usesMethodSplitting()
Review Comment:
Done in
[dc1c66d](https://github.com/apache/calcite/pull/3901/commits/dc1c66d14b38ad122312b99861fca20794701504)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
