davidradl commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1771040616
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/AbstractNode.java:
##########
@@ -51,7 +51,7 @@ public Type getType() {
}
@Override public String toString() {
- ExpressionWriter writer = new ExpressionWriter(true);
+ ExpressionWriter writer = new ExpressionWriter(true, true);
Review Comment:
> Ideally this would read from the CalciteSystemProperty but calcite-core
depends on linq4j so it can't be looked up here.
I do not know this code, but wonder if the split configuration values be
passed by value into the linq4j layer. If possible , this would avoid the
dependancy recursion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
