jduo commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1774179621
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/AbstractNode.java:
##########
@@ -51,7 +51,7 @@ public Type getType() {
}
@Override public String toString() {
- ExpressionWriter writer = new ExpressionWriter(true);
+ ExpressionWriter writer = new ExpressionWriter(true, true);
Review Comment:
I don't think this toString() method is used in code generation, just
logging/debugging.
This option is passed in to Expressions static functions, which is really
where ExpressionWriters are instantiated most of the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]