jduo commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1819076723
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableInterpretable.java:
##########
@@ -111,7 +111,9 @@ public static Bindable toBindable(Map<String, Object>
parameters,
parameters);
final ClassDeclaration expr = relImplementor.implementRoot(rel, prefer);
- String s = Expressions.toString(expr.memberDeclarations, "\n", false);
+ String s =
+ Expressions.toString(expr.memberDeclarations, "\n", false,
Review Comment:
@asdfgh19 , thanks for your comments. Would you be able to add tests for
your scenarios to the PR?
For this one, it seems like we a can pass expr to Expressions.toString(),
but I'm not sure what effect that has on the calls that depend on s (``
Hook.JAVA_PLAN.run(s);``)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
