jduo commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1819100244
##########
core/src/main/java/org/apache/calcite/rex/RexExecutorImpl.java:
##########
@@ -100,7 +100,9 @@ private static String compile(RexBuilder rexBuilder,
List<RexNode> constExps,
Expressions.methodDecl(Modifier.PUBLIC, Object[].class,
BuiltInMethod.FUNCTION1_APPLY.method.getName(),
ImmutableList.of(root0_), blockBuilder.toBlock());
- String code = Expressions.toString(methodDecl);
+ String code =
+ Expressions.toString(methodDecl,
Review Comment:
It seems that this code relates to RexExecutable. The method body is
generated here and written to String, then gets attached as the body of a class
in RexExecutable that's run directly in Janino's IClassBodyEvaluator. This will
be quite complicated to rework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
