asdfgh19 commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1805855177
##########
core/src/main/java/org/apache/calcite/rex/RexExecutorImpl.java:
##########
@@ -100,7 +100,9 @@ private static String compile(RexBuilder rexBuilder,
List<RexNode> constExps,
Expressions.methodDecl(Modifier.PUBLIC, Object[].class,
BuiltInMethod.FUNCTION1_APPLY.method.getName(),
ImmutableList.of(root0_), blockBuilder.toBlock());
- String code = Expressions.toString(methodDecl);
+ String code =
+ Expressions.toString(methodDecl,
Review Comment:
The methodDecl here is a MethodDeclaration, not a ClassDeclaration, so it
seems that the code splitting logic implemented in the ClassDeclaration does
not work here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
